-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-4038: Ensure retryable read OperationFailure
s re-raise exception when 0 or NoneType error code is provided.
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to add a test case into PyMongo to ensure this doesn't recur |
NoahStapp
approved these changes
Nov 13, 2023
ShaneHarvey
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs a mockupdb test where the server returns a missing or 0 error code.
Also could you update the PR title and changelog to describe the bug that's being fixed?
OperationFailure
s re-raise exception when 0 or NoneType error code is provided.
ShaneHarvey
approved these changes
Nov 15, 2023
NoahStapp
approved these changes
Nov 15, 2023
Jibola
added a commit
to Jibola/mongo-python-driver
that referenced
this pull request
Nov 15, 2023
…tion when 0 or NoneType error code is provided. (mongodb#1425) (cherry picked from commit 0ff6a87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://jira.mongodb.org/browse/PYTHON-4038
Pymongo is retrying a failed find connection ONCE that has a 0 or NoneType error code.
This is undesired behavior because if, theoretically, we introduce an error type that does not have an error code but is an instance of an
OperationFailure
, we will mistakenly retry leading to unexpected consequences.Added 3 tests: